Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies are rather strict, leading to conflicts #449

Closed
maresb opened this issue Sep 2, 2022 · 4 comments · Fixed by #454
Closed

Dependencies are rather strict, leading to conflicts #449

maresb opened this issue Sep 2, 2022 · 4 comments · Fixed by #454

Comments

@maresb
Copy link
Contributor

maresb commented Sep 2, 2022

The requirement packaging>=21.3 makes Hatch impossible to install it alongside Poetry 1.1. (Here the blame is definitely not entirely on Hatch!)

Also, click>=8.0.3 is less than a year old, and occasionally some package may pin click <8.

Since Hatch is a build tool which may be used in large environments alongside older dependencies, it would in general be nice if its dependencies were left a bit looser, perhaps vendoring newly introduced functionality. Or does Hatch make essential use of these new versions?

@ofek
Copy link
Collaborator

ofek commented Sep 3, 2022

@ofek
Copy link
Collaborator

ofek commented Sep 3, 2022

decreased import time

$ python -m timeit -n 1 -r 1 "import packaging.requirements"
1 loop, best of 1: 41 msec per loop
$ python -m pip install -qqq git+https://github.com/pypa/packaging
$ python -m timeit -n 1 -r 1 "import packaging.requirements"
1 loop, best of 1: 26.4 msec per loop

@maresb
Copy link
Contributor Author

maresb commented Sep 4, 2022

Hmm, if you're eager to always pin Hatch dependencies to recent versions and not support compatibility hacks, then perhaps it'd be helpful to more prominently recommend installing Hatch via pipx?

@ofek
Copy link
Collaborator

ofek commented Sep 4, 2022

eager to always pin Hatch dependencies to recent versions

Not really, more so eager to enforce fixes or features that directly affect Hatch. I don't set minimum versions arbitrarily 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants