-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always set owner's read bit, in files written #140
Labels
component: destinations
Related to WheelDestination and friends
type: task
Something that needs to be done that is not a bug or feature
Comments
Hmm... I'm wondering if this should be fixed in emscripten or if we should have a workaround here. @pmp-p Any specific preferences around this? |
well emscripten should be fixed, but installer should set both bits for file owner regardless of mask set for group/others. |
Fair enough. A PR fixing this, with tests would be very welcome! |
pradyunsg
added
the
type: task
Something that needs to be done that is not a bug or feature
label
Oct 25, 2022
pradyunsg
changed the title
make_file_executable may not set read bit
Always set owner's read bit in files written
Oct 25, 2022
pradyunsg
changed the title
Always set owner's read bit in files written
Always set owner's read bit, in files written
Oct 25, 2022
pradyunsg
added
the
component: destinations
Related to WheelDestination and friends
label
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: destinations
Related to WheelDestination and friends
type: task
Something that needs to be done that is not a bug or feature
on
sys.platform=="emscripten"
whereoct(os.umask(0)) == 0o777
by default instead of 0o22at
installer/src/installer/utils.py
Line 251 in 70ae05b
the execute bit is set but the user read one is lost making it impossible to preload libraries (.so). ( maybe make_file_loadable ? that set at least u+rx )
emscripten-core/emscripten#17269
The text was updated successfully, but these errors were encountered: