Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dist publishing guide should mention versioning restrictions #578

Open
webknjaz opened this issue Dec 7, 2018 · 4 comments
Open

Dist publishing guide should mention versioning restrictions #578

webknjaz opened this issue Dec 7, 2018 · 4 comments
Labels
good first issue type: enhancement A self-contained enhancement or new feature

Comments

@webknjaz
Copy link
Member

webknjaz commented Dec 7, 2018

It has a few paragraphs about local version identifiers https://packaging.python.org/guides/distributing-packages-using-setuptools/#local-version-identifiers where it has this not intended for publication phrase but doesn't clearly state that public indexes usually forbid local identifiers.

And uploading your project to PyPI section doesn't mention this: https://packaging.python.org/guides/distributing-packages-using-setuptools/#uploading-your-project-to-pypi
(It should probably advise using/integrating twine check before uploading dists)

P.S. Today I also suggested that twine check warns about this as well: pypa/twine#430

@theacodes
Copy link
Member

Thanks for filing this, @webknjaz!

This is a wonderful first issue for someone, so if you're up for it I encourage you to send a PR!

@lorarjohns
Copy link

I'm happy to take it this week if it's still needed! @theacodes

@webknjaz
Copy link
Member Author

webknjaz commented Dec 2, 2019

@lorarjohns I believe it's still needed. I think if you fully understand what to add, go ahead and create a PR.

@wholmgren
Copy link

I ran into a similar issue with the publishing using github actions guide https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#publishing-the-distribution-to-pypi-and-testpypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue type: enhancement A self-contained enhancement or new feature
Projects
None yet
Development

No branches or pull requests

5 participants
@theacodes @webknjaz @wholmgren @lorarjohns and others