Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version comparison #386

Closed
videns opened this issue Jan 15, 2021 · 2 comments
Closed

Wrong version comparison #386

videns opened this issue Jan 15, 2021 · 2 comments

Comments

@videns
Copy link

videns commented Jan 15, 2021

Use packaging.version.parse to compare software version. Have found such problem with openssl versions:

a = pckVersion.parse("1.1.1i")
b = pckVersion.parse("1.0")
b > a
True
@uranusjr
Copy link
Member

1.1.1i is not a valid PEP 440 version, so comparison against version.Version should either fall back to LegacyVersion or return NotImplemented. But with LegacyVersion being deprecated, this is probably not worth fixing.

@pradyunsg
Copy link
Member

See also the issues linked in (and discussion at) #321.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants