Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build command #27

Merged
merged 6 commits into from
Dec 17, 2018
Merged

Add build command #27

merged 6 commits into from
Dec 17, 2018

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Dec 12, 2018

This PR introduces pep517.build, modeled after pep517.check. Fixes #25.

As @pfmoore mentioned in that ticket, the README indicates the experimental nature of this first implementation of a build tool that can build an sdist for PEP 517 projects, and is the first that makes it possible to release some projects without invoking easy_install.

@jaraco
Copy link
Member Author

jaraco commented Dec 17, 2018

I'd like to move forward with releasing this functionality. As documented, it's "experimental", but it does provide the only usable concept for building dists on PEP 517.

Approving this PR (and releasing it) would also dramatically simplify the routines needed in jaraco/skeleton and this project for its release functionality.

I'd be happy to accept responsibility for deprecating and redirecting users to functionality in pip or other tools that obviates this functionality in the future as appropriate.

@pfmoore or @takluyver would you be willing to approve this PR?

@jaraco jaraco merged commit 9ca68d8 into master Dec 17, 2018
@jaraco jaraco deleted the feature/build-command branch December 17, 2018 17:13
@jaraco jaraco restored the feature/build-command branch December 17, 2018 17:21
@jaraco
Copy link
Member Author

jaraco commented Dec 17, 2018

I've had to restore the feature/build-command branch for now - as several projects are still referencing it. After a week or so it should be safe to delete it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants