Apply suggestions from code review

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>

Author: 3 people

src/pip/_internal/cli/parser.py

@@ -191,7 +191,7 @@ def _get_ordered_configuration_items(
                 # ignore empty values
                 if not value:
                     logger.debug(
-                        "Ignoring configuration key '%s' as it's value is empty.",
+                        "Ignoring configuration key '%s' as it's empty.",
                         key,
                     )
                     continue

tests/functional/test_configuration.py

@@ -111,6 +111,9 @@ def test_user_values(self, script: PipTestEnvironment) -> None:
         assert "freeze.timeout: 10" in result.stdout
         assert re.search(r"user:\n(  .+\n)+", result.stdout)
 
+        # Avoid state leaking for tests re-using the new config file
+        os.remove(new_config_file)
+
     def test_site_values(
         self, script: PipTestEnvironment, virtualenv: VirtualEnvironment
     ) -> None:
@@ -161,7 +164,7 @@ def test_config_separated(
 
         # Get legacy config file and touch it for testing purposes
         legacy_config_file = get_configuration_files()[kinds.USER][0]
-        os.makedirs(legacy_config_file.rsplit("/", 1)[0])
+        os.makedirs(os.path.dirname(legacy_config_file))
         open(legacy_config_file, "a").close()
 
         # Site config file