-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip install *.whl fails on Windows #10808
Comments
That's a difference in the Windows and Unix shells, not a bug in pip. On Unix, the shell expands |
Yes, I know. But from an end user perspective it is a frustrating behaviour change (which would be supported with the glob library when pip is run on Windows). So this is considered a won't fix? On the bright side, I have a work around now:
Double percentage signs not needed directly at the Windows terminal. |
I get your point, but making it "work" would be complex - because whether to expand is dependent on the shell, not the OS (bash on Windows is a thing, as is Powershell on Unix), so how would we write the logic? And we don't want to double-expand on shells that do expand, so "expand always" has its own issues. IMO, it's not so much "won't fix" as "far more complicated than it's worth". By the way, when you say "behaviour change", I assume you mean "works differently on different systems", not "used to work in older versions of pip"? Because I don't recall that we ever did a manual glob here, but I could be wrong... |
This isn't something that pip should handle IMO. This is a platform-specific feature, outside of pip, and I don't think we should try to reconcile differences across platforms. |
I've been away from Windows too long - things like this catch me by surprise. Thanks for the discussion, I agree we can close this. |
Description
On Linux and macOS I have scripted a build process which makes a wheel, and then (usually in in a clean environment) installs the wheel. The wheel filename depends on the version etc, and by construction there is only one wheel present.
This works on Linux and macOS:
The equivalent fails on Windows:
Expected behavior
I am expecting pip on Windows to expand the wildcard glob, and substitute the single matching filename.
If this is something you won't fix, suggestions for a workaround would be useful.
pip version
21.1.3
Python version
3.9.5
OS
Windows
How to Reproduce
Contrived test case:
Output
Expected behaviour is to interpret
*.whl
asempty.whl
, thus expect:ERROR: empty.whl is not a valid wheel filename
Actual:
Code of Conduct
The text was updated successfully, but these errors were encountered: