Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite assumes virtualenv installs setuptools #12121

Closed
1 task done
pfmoore opened this issue Jul 1, 2023 · 6 comments · Fixed by #12127
Closed
1 task done

Test suite assumes virtualenv installs setuptools #12121

pfmoore opened this issue Jul 1, 2023 · 6 comments · Fixed by #12127
Labels
S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior

Comments

@pfmoore
Copy link
Member

pfmoore commented Jul 1, 2023

Description

Running nox -s test-3.11 in a system that has virtualenv (globally) configured to not install setuptools or wheel, fails with the error

Traceback (most recent call last):
  File "C:\Work\Projects\pip\setup.py", line 4, in <module>
    from setuptools import find_packages, setup
ModuleNotFoundError: No module named 'setuptools'

Expected behavior

Test suite doesn't depend on the user's configuration being the default. (It's worth noting that I think virtualenv is going to stop installing setuptools in Python 3.12).

pip version

23.2.dev0

Python version

3.11.2

OS

Windows

How to Reproduce

  1. Put no_setuptools=True in your virtualenv.ini.
  2. Run nox -s test-3.11

Output

No response

Code of Conduct

@pfmoore pfmoore added type: bug A confirmed bug or unintended behavior S: needs triage Issues/PRs that need to be triaged labels Jul 1, 2023
@pfmoore
Copy link
Member Author

pfmoore commented Jul 1, 2023

I'm logging this as a reminder, it's not a critical issue right now

@uranusjr
Copy link
Member

uranusjr commented Jul 4, 2023

I think (did not check confirmed) this is also an issue for --use-venv on 3.12 since setuptools was removed from ensurepip.

@pradyunsg
Copy link
Member

(I've filed a support request, marking the above as spam)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@uranusjr @pfmoore @pradyunsg and others