Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 23.3 #12296

Closed
pfmoore opened this issue Sep 25, 2023 · 34 comments
Closed

Release 23.3 #12296

pfmoore opened this issue Sep 25, 2023 · 34 comments
Assignees
Labels
type: maintenance Related to Development and Maintenance Processes
Milestone

Comments

@pfmoore
Copy link
Member

pfmoore commented Sep 25, 2023

We're due to do 23.3 in October. Filing this issue to track that.

@pypa/pip-committers anyone up for being RM this time?

@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label Sep 25, 2023
@pradyunsg pradyunsg pinned this issue Sep 25, 2023
@sbidoul
Copy link
Member

sbidoul commented Sep 29, 2023

I can take it. I will probably do the release on the first or second weekend of October.

@sbidoul sbidoul added this to the 23.3 milestone Sep 29, 2023
@sbidoul
Copy link
Member

sbidoul commented Oct 1, 2023

@pradyunsg since #12300 is on a good track, let me know if you would plan to cut a packaging release in the coming week or so.

@pradyunsg
Copy link
Member

I'm hoping to do so today, if I end up having some time after I finish my household chores. :)

@pradyunsg
Copy link
Member

@sbidoul are there any specific PRs in the milestone that you'd like help with / want someone else to pick up over the coming days?

I can make some time to work on pip this weekend, if there's anything I can do to help out with the release. :)

@sbidoul
Copy link
Member

sbidoul commented Oct 6, 2023

@pradyunsg thanks. The main topic for now is #12300 (comment) (@uranusjr has already mentioned he might look into it). You may also want to review #11159.

I'm usually not too keen to do vendoring upgrades late in the cycle 1. I can do it just after release though.

Other than that I'm not aware of any urgent things to add to 23.3. If there are any, let me know.

Footnotes

  1. the packaging upgrade being a notable exception

@uranusjr
Copy link
Member

We may want to upgrade urllib3 just in case. See #12337.

@sbidoul
Copy link
Member

sbidoul commented Oct 12, 2023

Does our vendoring action support upgrading to a specific version? Because we want to stay with urllib3 < 2 for now.

@pfmoore
Copy link
Member Author

pfmoore commented Oct 12, 2023

You could probably update vendor.txt and then run vendoring sync (i.e., just nox -s vendoring with no arguments).

In fact, I just did this. You need to manually add the news fragment and commit, but it seems to work. #12343.

@Orionx86
Copy link

@pfmoore
Copy link
Member Author

pfmoore commented Oct 12, 2023

This release has certifi 2023.7.22.

@sbidoul
Copy link
Member

sbidoul commented Oct 14, 2023

I plan to release tomorrow evening, if life permits.

@sbidoul
Copy link
Member

sbidoul commented Oct 15, 2023

Release 23.3 in progress

@FlavioAmurrioCS
Copy link
Contributor

Does this release include distlib 0.3.7? Been waiting on this one for a while 🥲

Context:
pypa/distlib#203
#12151
https://pypi.org/project/distlib/0.3.7/

@sbidoul
Copy link
Member

sbidoul commented Oct 16, 2023

@FlavioAmurrioCS no one had done the distlib vendoring upgrade on time before the release so that will be for 24.0 in January.

@sbidoul
Copy link
Member

sbidoul commented Oct 19, 2023

I plan to do a patch release this weekend.

@sbidoul
Copy link
Member

sbidoul commented Oct 21, 2023

Release 23.3.1 in progress

@edmorley
Copy link
Contributor

There are a couple of possible regressions that would be good to fix in a 23.3.2 patch release:

@pradyunsg
Copy link
Member

@sbidoul Do you plan on cutting more bugfix releases?

@sbidoul
Copy link
Member

sbidoul commented Oct 31, 2023

I do. I'm waiting on the analysis about the extras issue to conclude. I don't have enough experience with that part of the code base to be of any help in the little time I have available, unfortunately.

@notatallshaw
Copy link
Member

notatallshaw commented Nov 16, 2023

Is #12392 going to get a release for 23.3 or is 23.3 done?

Funnily enough I just came across this at work today, happy to give it a test on my end and confirm on PR.

@sbidoul
Copy link
Member

sbidoul commented Nov 17, 2023

@notatallshaw I was planning to look at a last 23.3 patch release over the weekend. If you can test and confirm the fix that would be helpful.

@pfmoore
Copy link
Member Author

pfmoore commented Dec 4, 2023

@sbidoul Is there a reason there's no CPython PRs for the 23.3 releases?

@sbidoul
Copy link
Member

sbidoul commented Dec 4, 2023

There is a last bugfix to do, so I was waiting for that. Then life and work got in the way.
If #12392 is good to go I can do that end of this week.

@pfmoore
Copy link
Member Author

pfmoore commented Dec 4, 2023

What's in that release? Any security fixes? CPython 3.11.7 is being released, and there's a debate as to whether to release with pip 23.2.1 (what's there right now), 23.3.1 (contributed by a 3rd party) or wait for 23.3.2.

@pfmoore
Copy link
Member Author

pfmoore commented Dec 4, 2023

Looking at it, the Mercurial CVE fix had a bug in 23.3.1, which is fixed in 23.3.2. That's probably the key thing here.

@sbidoul
Copy link
Member

sbidoul commented Dec 4, 2023

I need to cherry-pick

Sorry there is no way I can handle that before end of this week. So if urgent either someone else can do 23.3.2, or ship the latest 23.2 with CPython 3.11.7)

@pfmoore
Copy link
Member Author

pfmoore commented Dec 4, 2023

The CPython RM has decided to release 3.11.7 with 23.2.1. So we can simply continue with the 23.3.2 release as normal, and create a CPython PR when it's done.

@sbidoul
Copy link
Member

sbidoul commented Dec 17, 2023

Release 23.3.2 in progress

@pradyunsg
Copy link
Member

@sbidoul Do you plan to file a CPython PR? If not, I can create one tomorrow.

@sbidoul
Copy link
Member

sbidoul commented Dec 17, 2023

@pradyunsg I plan to do it early in the week. Just waiting a little bit to be sure nothing surprising shows up.

@hugovk
Copy link
Contributor

hugovk commented Dec 17, 2023

Python 3.13.0a3 is planned for Tuesday, would be nice to have it in there, but I don't think it's essential:

https://peps.python.org/pep-0719/#schedule

The next 3.11 and 3.12 releases are in February.

@sbidoul
Copy link
Member

sbidoul commented Dec 18, 2023

The CPython PR is ready.

@sbidoul
Copy link
Member

sbidoul commented Dec 18, 2023

And with this, I'm closing the 23.3 release cycle.

@sbidoul sbidoul closed this as completed Dec 18, 2023
@sbidoul sbidoul unpinned this issue Dec 18, 2023
@pradyunsg
Copy link
Member

Thanks @sbidoul for doing this, and @pfmoore for landing the CPython PRs and backports!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

No branches or pull requests

10 participants