pip ignores --global-option and --install-options when installing from a VCS url

[rainwoodman]

Environment

• pip version: 10.0.1
• Python version: 3.6.5
• OS: Linux

Description
pip 10.0.1 ignores --install-options installing from git+git://

Likely related to

#5251

$ pip install --ignore-installed --no-deps --install-option="--prefix=/tmp/test-install" git+git://github.com/bccp/nbodykit

$ ls /tmp/test-install
ls: cannot access '/tmp/test-install': No such file or directory

However, installing from zip works:

$ pip install --ignore-installed --no-deps --install-option="--prefix=/tmp/test-install" http://github.com/bccp/nbodykit/archive/master.zip

$ ls /tmp/test-install
lib

Expected behavior
installing from VCS shall be no different than from a zip file.

How to Reproduce
See above.

Output

See above.

[pradyunsg]

This looks like a bug to me. I don't have the bandwidth to investigate though. :(

[jwhite007]

Environment

• pip version: 18.0
• Python version: 3.7.0 (installed via Linuxbrew)
• OS: Red Hat Enterprise Linux Server release 6.6 (Santiago)

Description
Same thing happens for me using git with ssh. The following installs to Python 3.7.0's site-packages and not to <path to dir>/lib/Python3.7/site-packages/ as expected.

$ pip3 install --install-option="--prefix=<path to dir>" git+ssh://<host>:<repo>

The following does install to <path to dir>/lib/Python3.7/site-packages/ as expected

$ git clone <host>:<repo>
$ pip3 install --install-option="--prefix=<path to dir>" ./<repo>

Both installations give UserWarning: Disabling all use of wheels due to the use of --build-options / --global-options / --install-options.

The former (install from git via ssh) also gives

Building wheels for collected packages: cgldb
  Running setup.py bdist_wheel for cgldb ... done
  Stored in directory: /tmp/pip-ephem-wheel-cache-z3m391el/wheels/a8/99/4d/eebf5e88bdd2909e65353b3ccc03761facab89925a55faf3f6

[kneufeld]

Can confirm that this is still an issue with pip 19.0.1 and git+https

[cjerdonek]

Someone reported this issue again as #6379 (but for --global-option rather than --install-option).

I diagnosed it there in this comment and am copying my findings here since that issue is now closed as a duplicate:

When --global-option (or --install-option) is passed, pip disallows binaries for that requirement:

pip/src/pip/_internal/cli/cmdoptions.py

Lines 72 to 79 in 78744e8

	names = ["build_options", "global_options", "install_options"]
	if any(map(getname, names)):
	control = options.format_control
	control.disallow_binaries()
	warnings.warn(
	'Disabling all use of wheels due to the use of --build-options '
	'/ --global-options / --install-options.', stacklevel=2,
	)

However, when pip gets to the point where it needs to decide whether to build a wheel or fall back to using setup.py, it looks at whether it's a VCS checkout before checking whether binaries were disallowed:

pip/src/pip/_internal/wheel.py

Lines 766 to 776 in 78744e8

	if req.link and not req.link.is_artifact:
	# VCS checkout. Build wheel just for this run.
	return True
	if "binary" not in format_control.get_allowed_formats(
	canonicalize_name(req.name)):
	logger.info(
	"Skipping bdist_wheel for %s, due to binaries "
	"being disabled for it.", req.name,
	)
	return None

So the fix should be pretty simple (just reverse those two checks, I believe).

[cjerdonek]

I posted PR #6389 to address this.