-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 18.1 #5782
Comments
We need a PEP update for pypa/wheel#249 to be merged, which is a blocker for dropping dependency links and we should get that resolved sooner than later. |
I don't have the free time at the moment, so I'm happy for you to be RM. |
Same for me :) |
I've commented on issues about expecting merged PRs by 30th or the change not making it into 18.1. I've also trimmed the milestone of things that'd obviously not be ready in time. There's one release blocker currently - #5702 - which exhibits breakage of isolation of venv. I've not had the time to look into it so if someone else can, that'd be nice. There's some concerns raised by @benoit-pierre in #5780 about PEP 508 URLs not being a good-enough replacement for dependency links. That's a discussion that we might want to have there, prior to the release but it's not urgent since we can just push the removal date for dependency-links to a later date if that's deemed necessary. As per @pfmoore's suggestion elsewhere, last release I'd pushed items that were missed from 18.0 to the 18.1 milestone. This time, instead of pushing into the next milestone, I've simply dropped them from the milestone. If there's interest, those items can be added to a later milestone when the time comes. Other than that, I'll be making a Ideally, I'd like to get 18.1 out before the first weekend of October (2-4 Oct); if we miss that window, I'll have time in the following week (13-14 Oct) or just before/during the Bloomberg PyPA Sprint (24-29 Oct). |
Is #5702 really a release blocker? It's been round since 10.1 according to the report itself, and it seems pretty much inherent in how If it's to be a release blocker, what's the plan for fixing it? There doesn't seem like an obvious way forward apart from making some sort of special case exceptions to the current (logical) behaviour. And I'm not sure we want to rush down that sort of path - surely better to address #1668 directly, rather than adding stopgap solutions? IMO, we shouldn't hold up the release for #5702. |
As noted, I've basically not had the time to take a good look at it yet. I trust your judgement here, so I'll drop the blocker label on it. |
Huh. I missed #4557 because it is a PR. :/ I've gone ahead and dropped the same from 18.1. @pypa/pip-committers Let's slow down and put a hold on merging PRs until the release, which should be within the coming week. |
Heads up: I'll be making the release within the next 24 hours. Sorry for blocking merges to master for so long. |
pip 18.1 has been released to PyPI and TestPyPI. Making changes to reopen master for development. |
|
And, the distutils-sig announcement is done. |
We need to have some minor process discussions as per #5853; I'll file them later. If someone else has time to files issues for initiating the same discussions before that, please feel free to do so. |
Well, it's been ~20 days since 18.1 went out but I've been AWOL due to a lot of college work. Is there anything that would demand a pip 18.1.1? My understanding is that that's not needed since the issues that came up were not-so-critical documentation-only ones. |
Considering no one commented, I don't think so. Wrapping up 18.1 now! Thanks everyone who worked on this and contributed to discussions/code! :) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
October is ~2 weeks away so, here's another issue for discussing the next release. :)
This time too, I think there's enough that's been merged to justify making a new release.
I am willing to be the release manager for this release. I'll be happy to defer to someone else who wants to do it.
The text was updated successfully, but these errors were encountered: