Test call_subprocess more thoroughly; fix spinner edge cases #6312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
force-pushed
the
subprocess-tests-and-spinner-fixes
branch
from
f5b9256
to
cd5984d
Compare
cjerdonek
force-pushed
the
subprocess-tests-and-spinner-fixes
branch
3 times, most recently
from
6edb20b
to
c7f8a2b
Compare
cjerdonek
force-pushed
the
subprocess-tests-and-spinner-fixes
branch
from
c7f8a2b
to
9a4967b
Compare
cjerdonek
force-pushed
the
subprocess-tests-and-spinner-fixes
branch
from
9a4967b
to
fe79372
Compare
|
@pradyunsg Would you be able to take a look at this PR? It mostly consists of adding tests (the first commit), but it also fixes a couple spinner edge cases (the second commit). |
|
Yep. |
pradyunsg
approved these changes
Mar 12, 2019
|
Thanks, @pradyunsg. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to test
call_subprocess()more thoroughly for a subsequent PR.However, in the process I noticed a couple edge cases with the spinner that this PR fixes. They are--
The spinner says
errorif the return code was non-zero but was one of the passedextra_ok_returncodes(and so should be acceptable). The spinner should instead saydone.The spinner reports a final
done/errorfinishing message even if the spinner wasn't actually used (e.g. in the case thatshow_stdoutwas true).Both of these fixes can be seen in the changes in the test expectation in the second commit of this PR.