Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pip._internal.utils.ui to pip._internal.cli.* #6531

Closed
pradyunsg opened this issue May 25, 2019 · 4 comments · Fixed by #6727
Closed

Move pip._internal.utils.ui to pip._internal.cli.* #6531

pradyunsg opened this issue May 25, 2019 · 4 comments · Fixed by #6727
Labels
auto-locked Outdated issues that have been locked by automation type: refactor Refactoring code
Milestone
Internal Cleansing

Comments

@pradyunsg
Copy link
Member

It would be a good idea to move pip's CLI helpers that live in utils into the cli subpackage within pip.

This can also be an opportunity to separate the code for spinners and the code for progress bars into separate modules and introduce tests for the same.
@pradyunsg pradyunsg added the type: refactor Refactoring code label May 25, 2019
@pradyunsg pradyunsg added this to the Internal Cleansing milestone May 25, 2019
@pradyunsg
Copy link
Member Author

Related to #6541

Maybe, we'll have a pip._internal.ui package instead?

@sinscary
Copy link
Contributor

sinscary commented Jun 7, 2019

@pradyunsg Would love to take this up?

@pradyunsg
Copy link
Member Author

Please do! :)

@sinscary
Copy link
Contributor

sinscary commented Jul 2, 2019

@pradyunsg I have been bit busy. I am looking into it and will send a PR soon.

@sinscary sinscary mentioned this issue Jul 18, 2019
Merged
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Mar 22, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation type: refactor Refactoring code
Projects
None yet
Milestone
Internal Cleansing
Development

Successfully merging a pull request may close this issue.

Move ui helpers to cli subpackage sinscary/pip
2 participants
@pradyunsg @sinscary