Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled CI runs are broken #9782

Closed
pradyunsg opened this issue Apr 5, 2021 · 2 comments · Fixed by #9814
Closed

Scheduled CI runs are broken #9782

pradyunsg opened this issue Apr 5, 2021 · 2 comments · Fixed by #9814

Comments

@pradyunsg
Copy link
Member

I think this actions run is the latest CI against main, but it seems to be broken. So I can't be sure if main is passing the tests in CI right now...

Originally posted by @pfmoore in #9761 (comment)

@pradyunsg
Copy link
Member Author

Looking into this, it seems to be because we're using a CI check for "what changed" to run CI, and getting that answer on the regular scheduled runs is difficult for the determine-changes action we're using.

I'm sitting and thinking about this for a bit now, so if anyone has bright ideas, lemme know. :)

@sbidoul
Copy link
Member

sbidoul commented Apr 24, 2021

@pradyunsg the problem is not only on scheduled runs, as seen on current main:

image

An unconditional checkout in determine-changes fixes it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants