-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extraneous virtualenv created when installing VCS dependencies using --system
#1991
Comments
per #1939 and #1979 you need to include a lockfile -- see #1002 (comment) editable vcs dependencies require you to do dependency resolution which always requires a virtualenv |
@techalchemy I am a little confused by the statement: This is the output - it happens after it's installed all the editable/local dependencies, and can take 20mins or so.
|
@joejuzl the No, |
So the contents of my
I have attached the They are both in the directory This is my docker file:
I have attached the output of my docker build up until it hangs for 20mins creating a lock file. After that point it just continues to install all the non-editable dependencies. If you need anything else, let me know! This only happens on 11.10.0 not 11.9.0 Thanks! |
Hi @techalchemy while PR #2006 does seem like a bug, it doesn't fix the issue I am referring too! |
@joejuzl try |
I get this error when running
|
@joejuzl the comment directly above yours describes a temporary fix, I’ll have a release out in an hour or so |
This error is still occuring, is there any recommended fix? |
I noticed an issue in my docker builds this morning using this
Dockerfile
:(Pretty standard stuff, I don't believe Docker is the issue here)
Here is a log of the docker build:
{'implementation_name': 'cpython',
'implementation_version': '3.6.4',
'os_name': 'posix',
'platform_machine': 'x86_64',
'platform_python_implementation': 'CPython',
'platform_release': '4.9.87-linuxkit-aufs',
'platform_system': 'Linux',
'platform_version': '#1 SMP Wed Mar 14 15:12:16 UTC 2018',
'python_full_version': '3.6.4',
'python_version': '3.6',
'sys_platform': 'linux'}
Contents of
Pipfile.lock
('/app/Pipfile.lock'):Expected result
A new virtualenv should not be created when editable dependencies are encountered using
--system
.Actual result
If you look in the logs above, there's a new virtualenv created within the container that only contains
stratatilities
(look forVirtualenv location: /root/.local/share/virtualenvs/app-4PlAip0Q
). I believe this is related to recent 11.10.0 changes (potentially #1812?) because this behavior does not occur when pinning pipenv to 11.9.0.Steps to replicate
A similar
Dockerfile
that installs w/ a Pipfile that installs django via vcs has the same behaviorSorry if this is super verbose but I hope it helps everyone involved track it down.
The text was updated successfully, but these errors were encountered: