Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activate PIPENV_VENV_IN_PROJECT with --local #2086

Open
kennethreitz opened this issue Apr 29, 2018 · 3 comments
Open

activate PIPENV_VENV_IN_PROJECT with --local #2086

kennethreitz opened this issue Apr 29, 2018 · 3 comments
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. hacktoberfest Type: Enhancement 💡 This is a feature or enhancement request.
Milestone

Comments

@kennethreitz
Copy link
Contributor

No description provided.

@Enteleform
Copy link

Enteleform commented Jul 23, 2018

Compimentary Feature Proposal

Replace the hardcoded ".venv" value with a dir parameter that defaults to ".venv"
 

Examples:

PIPENV_VENV_IN_PROJECT=false
C:\TEMP> pipenv install

>>> C:\Users\Enteleform\.virtualenvs\VENVS-SaQNVeuu
PIPENV_VENV_IN_PROJECT=true
C:\TEMP> pipenv install

or

C:\TEMP> pipenv install --local
C:\TEMP> pipenv install -l

>>> C:\TEMP\.venv
C:\TEMP> pipenv install --dir __env__
C:\TEMP> pipenv install -d __env__

>>> C:\TEMP\__env__

 

Exposing the parameter seems simple enough, although I'm not sure how it would affect commands like
pipenv install somepackage
or
pipenv shell

Ideally pipenv would automatically resolve the directory with the default command syntaxes, but as a user with strong filesystem preferences; even having to include the --dir switch on all commands would be better than nothing.

@GitShaffi
Copy link

GitShaffi commented Oct 26, 2018

Have created the below PR to fix this.
#3108

pipenv install --local
or
pipenv install -l

will now create the venv directory within the project.

@matteius matteius added hacktoberfest Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. and removed help wanted Type: API Change This issue describes an API change. labels Sep 13, 2022
@matteius
Copy link
Member

matteius commented Mar 2, 2023

I am thinking we would be better off adding a pipenv activate command at this point that activates whichever the appropriate project virtualenv is determined by the same logic as pipenv --venv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. hacktoberfest Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

No branches or pull requests

5 participants