Implement our own subshell logic #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
feature/repatch-shell-detection
branch
from
9522c7c
to
525b901
Compare
uranusjr
force-pushed
the
feature/repatch-shell-detection
branch
5 times, most recently
from
065b50b
to
7ab61ba
Compare
To replace Pew's "workon" command. New code built on Shellingham. This also fixes a few additional minor bugs, e.g. Cmder not launching Powershell when it should.
uranusjr
force-pushed
the
feature/repatch-shell-detection
branch
from
7ab61ba
to
198e618
Compare
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
|
merging! |
|
I'm surprised that this doesn't seem to fix #876 since that was a bug with pew. Is there a different bug with Shellingham? |
|
Unfortunately Shellingham does many things the same as Pew. It fixes a lot of things, but not all of them. But it’d be possible to work on it now, at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all
pew workonusages, and implement the subshell functionality from scratch based on Shellingham.With real shell detection on POSIX implemented, the subshell now defaults to match parent shell, instead of login shell. This would help reduce surprising behaviour such as #1762.
I tested the code on Windows and Ubuntu (WSL) in both fancy and compat mode, and am fairly confident this implementation is reasonably complete. It would probably still be a good idea to rigorously test this manually on various platforms before releasing it to the public.
This also fixes #915 (a bug in Pew).