Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help text doesn't appear in command --help #2381

Closed
ghost opened this issue Jun 18, 2018 · 5 comments
Closed

Help text doesn't appear in command --help #2381

ghost opened this issue Jun 18, 2018 · 5 comments
Labels
good first issue Issues suitable as a newcomer to get familiar with Pipenv! Type: Enhancement 💡 This is a feature or enhancement request.

Comments

@ghost
Copy link

ghost commented Jun 18, 2018

$ pipenv --version
pipenv, version 2018.05.18

$ pipenv check --help
Usage: pipenv check [OPTIONS] [ARGS]...

Options:
  --three / --two  Use Python 3/2 when creating virtualenv.
  --python TEXT    Specify which version of Python virtualenv should use.
  --system         Use system Python.
  --unused TEXT    Given a code path, show potentially unused dependencies.
  -h, --help       Show this message and exit.

There's a field called short_help ("Checks for security vulnerabilities and against PEP 508 markers provided in Pipfile.") which appears when running pipenv alone, but it doesn't appear when running pipenv check --help. It probably should appear there, because that's what people run when they want to know what pipenv check does.

See also: #1155

@uranusjr
Copy link
Member

Contributions are welcomed!

@uranusjr uranusjr added Type: Enhancement 💡 This is a feature or enhancement request. good first issue Issues suitable as a newcomer to get familiar with Pipenv! labels Jun 19, 2018
@toxinu
Copy link

toxinu commented Jun 22, 2018

In order to have short_help printed with pipenv check command we must declare help text as command function docstring. Is it something we want to do?

Side-effect is that help will be truncated by click like that:

Commands:
  check      Checks for security vulnerabilities and...
  clean      Uninstalls all packages not specified in Pipfile.lock.

Strange behavior that click doesn't show sort_help when running pipenv check as excepted...

@techalchemy
Copy link
Member

We have a giant blob of text with this info in core.py which might be what you’re looking for

@erinxocon
Copy link
Contributor

This has been fixed and approved in #2578

@erinxocon
Copy link
Contributor

Thanks @sup 🌈🍰🌈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues suitable as a newcomer to get familiar with Pipenv! Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

No branches or pull requests

4 participants