-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Jinja2 templates for click_completion #2422
Conversation
@techalchemy We’ll need another release very soon 🤦♂️ |
Today is the plan |
Is this sufficient to make sure they end up in the sdist too? |
@ilovezfs It should, I think. |
@ilovezfs @uranusjr Hi — sadly it looks like the latest commit of master, with this PR merged, does not include the files in the sdist under setuptools 39.0.1, as I am just discovering now 😂 . I don't really grok Python packaging sometimes, but I have found adding For completeness I have tried CPython 3.6.5 and 2.7.15 on MacOS high sierra. The sdist as generated there is affected, as is the one installed by homebrew on my system. Please advise if I'm somehow using a bad branch, but the merge commit for this PR is in the git log so I'm pretty sure it's in there. |
We didn’t actually release an sdist yet but I would believe that our manifest doesn’t include these. Feel free to PR a fix and thanks for the heads up! |
The new version of click_completion requires its Jinja2 templates to be installed along with the package in order to work. If not, any invocation of
pipenv --completion
results in ajinja2.exceptions.TemplateNotFound
for the template in question.I’ve just trivially added the pattern to
setup.py
, and tested that it works.