Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke vendoring script on CI #2428

Closed
hroncok opened this issue Jun 26, 2018 · 6 comments
Closed

Invoke vendoring script on CI #2428

hroncok opened this issue Jun 26, 2018 · 6 comments
Labels
Category: Tests Relates to tests. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Milestone

Comments

@hroncok
Copy link
Contributor

hroncok commented Jun 26, 2018

Is your feature request related to a problem? Please describe.

I'm always frustrated when I try to update the vendoring script but I'm hit by unrelated issues.

Describe the solution you'd like

This could be solved by having the vendoring script being run as part of the Continues Integration (Travis CI e.g. has daily cron as well).

Describe alternatives you've considered

Prove that the vendoring script is always reproducible.

Additional context

#2426 (comment)

@techalchemy
Copy link
Member

I am +1 on this as well, have been meaning to do this but yeah, it's on the list. You know how it is. I have to test it before every release and it's always basically what you experienced.

@hroncok
Copy link
Contributor Author

hroncok commented Jun 26, 2018

I don't see Travis CI enabled. Would a PR with this being run on Travis be accepted?

@erinxocon
Copy link
Contributor

@hroncok We use buildkite for unix testing, and VSTS for windows testing. We'll have to figure out how to integrate them on those platforms.

@techalchemy
Copy link
Member

I just pr'ed it (we also use appveyor currently)

We really need to sort out how to make buildkite publicly visible...

@techalchemy techalchemy added Category: Tests Relates to tests. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv. labels Jun 28, 2018
@techalchemy techalchemy added this to the 2018.7.0 milestone Jun 28, 2018
@uranusjr
Copy link
Member

For the vendoring process itself, would it a good idea to use a bot? I know there’re already mentions of this idea, we can use it to make sure a PR provides news fragments, and (if needed) generate patch files.

@techalchemy
Copy link
Member

I’d love that. Would need to get time to set this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Tests Relates to tests. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Projects
None yet
Development

No branches or pull requests

4 participants