Improve import times and runtimes #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before PR: ~/g/pypa-pipenv time -p pipenv --venv
/home/hawk/.virtualenvs/pypa-pipenv-PuUpLSqX
real 0.93
user 0.84
sys 0.08After PR: ~/g/pypa-pipenv import-time-improvement
/home/hawk/.virtualenvs/pypa-pipenv-PuUpLSqX
real 0.31
user 0.26
sys 0.04 |
- Lazily import requirementslib Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
- Pew import is super expensive - Fixes #2843 Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
force-pushed
the
import-time-improvement
branch
from
f45e72a
to
547110b
Compare
uranusjr
reviewed
Jul 1, 2018
pipenv/core.py
Outdated
| @@ -139,6 +132,8 @@ def which(command, location=None, allow_global=False): | |||
|
|
|||
| # Disable warnings for Python 2.6. | |||
| if 'urllib3' in globals(): | |||
| import urllib3 | |||
| from urllib3.exceptions import InsecureRequestWarning | |||
| urllib3.disable_warnings(InsecureRequestWarning) | |||
There was a problem hiding this comment.
I think this can be eliminated altogether. We don’t support 2.6 anymore.
Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipenv run --helpcrashes #2843Signed-off-by: Dan Ryan dan@danryan.co