pipenv install blows up with a TypeError #2559
Comments
|
the question is really, how did the key come to be written as non-unicode? But we can fix this by doing better assurances . While it is easier to simply use strings, that is not really a good approach. Unicode exists for a lot of reasons and we do absolutely need to use it. |
|
IMO the correct way to achieve Python 2/3 support is to always use Unicode, not The comment in the s = simplejson.dumps( # Send Unicode in to guarentee Unicode out.
content, indent=4, separators=(u",", u": "), sort_keys=True
)shows that we (I?) were very concious about always using Unicode, just not doing it correctly. |
|
I'm not a maintainer so I guess I won't argue much about the implementation, whatever is convenient for y'all, though yes I certainly do disagree :). Anything else I can provide here to help track this down? |
|
Hmmmm did you already have a pipfile here? If so we might be a bit Unicode aggressive as you say. We are supposed to respect existing pipfile encoding |
|
So, that command above is a reproducer on this machine ( |
|
OK, this still fails with |
|
You have your locale set? |
|
Normally yes (though with I just found the problematic code though, it's here: https://github.com/pypa/pipenv/blob/master/pipenv/utils.py#L1262 Where that's assembling a dict with |
|
I had the same problem. Can we fix it in package too? Then Edit: I guess it's about encoding of interaction between python and shell? How can we solve this permanently within the pipenv? |
|
My locale is appropriately set, see the original env dump at the top. The code I linked doesn't depend on the locale anyhow. |
|
Thanks for the debugging effort, and yeah, makes sense to me. For that I guess you’d need |
|
I’m updating #2561 to also ensure the lock file gets |
|
Getting this identical problem with most recent release, but I only get it when using pyenv. |
Issue description
Running
pipenv install fooblows up with bytes being passed around where unicode is expected.Expected result
foo is installed.
Actual result
Steps to replicate
Instrumenting
pipenv.projectto just have it print the reprs of what it's trying to do shows that it's trying to callsimplejson.dumpsonproducing
which is a
str(this is Py2).Note that things like the
versionkey there in the dict has bytes as its value, not unicode (and despite a comment in the code there saying " # Send Unicode in to guarentee Unicode out.", which the code at least locally there seems to expect to be receiving).(Possible aside: from just glancing at that function, it seems like it's suffering from trying to use unicode on both Py2 and Py3, rather than using native strings on Py2 and Py3, which IME is way easier to do when dealing with files.)
$ pipenv --support
Pipenv version:
'2018.7.1'Pipenv location:
'/Users/Julian/.local/share/virtualenvs/pipenv/site-packages/pipenv'Python location:
'/Users/Julian/.local/share/virtualenvs/pipenv/bin/python'Other Python installations in
PATH:2.7:/usr/local/bin/python2.72.7:/usr/local/bin/python2.72.7:/usr/bin/python2.73.7:/usr/local/bin/python3.7m3.7:/usr/local/bin/python3.72.7.13:/Users/Julian/.local/bin/python2.7.15:/usr/local/bin/python2.7.10:/usr/bin/python2.7.15:/Users/Julian/.local/bin/python22.7.15:/usr/local/bin/python23.7.0:/usr/local/bin/python3PEP 508 Information:
System environment variables:
ANSIBLE_CONFIGANSIBLE_HOSTSANSIBLE_RETRY_FILES_SAVE_PATHANSIBLE_VAULT_PASSWORD_FILEAWS_CONFIG_FILEAWS_SHARED_CREDENTIALS_FILEApple_PubSub_Socket_RenderBOTO_CONFIGBROWSERBUNDLE_CONFIGCENTOS_7_AMICHEF_PATHCOLORFGBGCOLORTERMCOMMAND_MODECTAGSDELETE_ON_TERMINATIONDEVELOPMENTDISPLAYDOCKER_CONFIGEDITORGEM_HOMEGEM_SPEC_CACHEGIT_TEMPLATE_DIRGNUPGHOMEGPG_TTYHOMEHTTPIE_CONFIG_DIRINPUTRCIS_DEVELOPMENT_WORKSTATIONITERM_PROFILEITERM_SESSION_IDLANGUAGELEIN_HOMELESSHISTFILELOGNAMELS_COLORSM2_HOMEMAGNETIC_DEVELOPMENTMYSQL_HISTFILENOTMUCH_CONFIGNPM_CONFIG_USERCONFIGNVIM_TUI_ENABLE_CURSOR_SHAPEOLDPWDPATHPERL5LIBPERL_CPANM_HOMEPERL_LOCAL_LIB_ROOTPERL_MB_OPTPERL_MM_OPTPIP_CONFIG_FILEPSQL_HISTORYPWDPYTHONDONTWRITEBYTECODEPYTHONSTARTUPPYTHONWARNINGSPYTHON_TEST_RUNNERSECURITYSESSIONIDSHELLSHLVLSSH_AUTH_SOCKSTARDICT_DATA_DIRTASKRCTERMTERM_PROGRAMTERM_PROGRAM_VERSIONTERM_SESSION_IDTMPDIRTMUXTMUX_PANEUSERVIRTUALENVSXDG_CACHE_HOMEXDG_CONFIG_HOMEXDG_DATA_HOMEXDG_DESKTOP_DIRXDG_DOCUMENTS_DIRXDG_DOWNLOAD_DIRXDG_MUSIC_DIRXDG_PICTURES_DIRXDG_PUBLICSHARE_DIRXDG_TEMPLATES_DIRXDG_VIDEOS_DIRXINITRCXPC_FLAGSXPC_SERVICE_NAMEZDOTDIRZSHPLUGINS__CF_USER_TEXT_ENCODINGC_INCLUDE_PATHCPLUS_INCLUDE_PATHGOPATHLIBRARY_PATHLD_LIBRARY_PATHPKG_CONFIG_PATHNODEPATHPYTHONPATHHGRCPATHWORKON_HOMELANGLC_ALL_PIP_PYTHON_PATHPipenv–specific environment variables:
Debug–specific environment variables:
PATH:/Users/Julian/.local/bin:/usr/local/bin:/usr/local/sbin:/Users/Julian/.local/share/gem/bin:/Users/Julian/Library/Application Support/go/bin:/usr/local/share/pypy:/usr/local/share/pypy3:/usr/local/share/npm/bin:/usr/local/opt/coreutils/libexec/gnubin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/Applications/Wireshark.app/Contents/MacOS:/Users/Julian/Library/Application Support/perl5/binSHELL:/usr/local/bin/zshEDITOR:nvimLANG:en_US.UTF-8PWD:/Users/Julian/DesktopThe text was updated successfully, but these errors were encountered: