Clarify pipenv install documentation
#2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`if no packages are given` sounds a bit better than `if none is given` when referring to `provided packages`. Also mention that `pipenv install` with no provided packages installs all packages from Pipfile. It is not obvious for people new to pipenv whether pipenv is using Pipfile or Pipfile.lock by default.
|
PS: thank you for all the hard work you've shared with us! |
|
Looks reasonable to me. Would you mind adding a fragment to the |
|
Sure thing! I've added a commit with the news fragment. Please let me know what you think. |
By default, `pipenv install` will install packages based on the list in `Pipfile`, not `Pipfile.lock`. `pipenv install --dev` is no exception. I've tested this using pipenv 2018.7.1 with different package versions in `Pipfile` and `Pipfile.lock`. After `pipenv install`, the versions in `Pipfile` were the ones actually installed.
|
@uranusjr I've found another small issue in the documentation, so I've added a new commit. Please let me know what you think. |
The previous help text made it seem that `pipenv install --dev` would install ONLY dev-packages, which is not the case. The current description is identical to the one used in the documentation, which is a lot clearer.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if no packages are givensounds a bit better thanif none is givenwhen referring toprovided packages.Also mention that
pipenv installwith no provided packagesinstalls all packages from Pipfile. It is not obvious for
people new to pipenv whether pipenv is using Pipfile or
Pipfile.lock by default.