-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully support pip options on install #287
Comments
Hey @JamesRamm, thanks for taking the time to open this. So this seems similar to #251 which we discussed other specific options for I entertained the "unknown" option when we were looking into #251 but this has a couple of issues that we didn't like. We lose command correction, so if the user types Is there a specific option you're currently not able to use with pip install? |
@nateprewitt Pip has its own error reporting if you pass unknown stuff, so you could generally leave it to pip to catch any 'unknown to pip' options which are passed in the 'unknown to pipenv' options. I suppose you could intercept pip error messages to report them in pipenvs' style. I'd still consider it to be less work than adding pip commands on a case-by-case basis. As for specific options, there are a few I use regularly such as 4, 5 and 6 from the examples shown here: |
So the example I'm worried about isn't that Click won't recognize defined parameters. It's the case where use user mistypes a command and instead of being asked "Did you mean --three?", pipenv just ignores it.
All of these are currently supported by pipenv in it's current state. If you look at the documentation for Pipfile, you'll find the sytanx for specifying The only additional features I can find that the unknown arguments problem solves are |
Hey @JamesRamm, I'm going to close this for now since we appear to already handle your desired use cases in Pipfile. Please feel free to reopen this is you're having problems with this functionality or have further related discussion points. Thanks! |
👍 |
Not a huge problem, but we ran into a bit of trouble migrating to pipenv due to not being able to supply |
@benkuhn All pip arguments can be specified as environment variables. You can set |
Wow, thanks for the tip! Don't know how I missed that in the Pip docs :) |
First, thanks for great project 👍
The main thing stopping me from using it is its' support for
pip install
.Currently,
pipenv
is parsing arguments forinstall
and then recreating thepip
argument string from them (pip_install
).This allows it to support its own options, but means pip compatibility is limited - e.g. installing in editable mode (
-e
) or installing from VCS.It would be possible to support all
pip install
options by simply forwarding unknown options onpipenv install
topip install
(http://click.pocoo.org/5/advanced/#forwarding-unknown-options). This would also mean no development required to support future pip changes.Is that feasible?
The text was updated successfully, but these errors were encountered: