Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018.11.14 regression: Installing Multiple local editable packages leaves some unusable #3236

Closed
christek91 opened this issue Nov 16, 2018 · 2 comments

Comments

@christek91
Copy link
Contributor

Issue description

We use pipenv to install five packages from local directories as 'editable' packages. In the most recent version of pipenv we see that when we do a pipenv install of those packages they report success and appear to succeed in the logs. However, we are unable to import them due to ModuleNotFoundError: No module named XXX.

Expected result

We are used to being able to install all five local editable packages, and then being able to import them in code that uses the virtualenv.

Actual result

Pipenv installs and reports exit code 0. However, importing modules gives a ModuleNotFoundError.

The logs report no errors, and verbose logs show the same actions being performed in the older and newer versions of pipenv.

Steps to replicate

Create a Pipfile that has 3 or more entries of the form:

"my_module" = {path = "./path/to/module", editable = true}

Then run pipenv install and try to import all those modules. You will likely get the import error.


Rather than paste the pipenv --support output, I've actually already got a fix and a test for it ready to go.

I spent enough time going down the rabbit hole today that I figured I'd take a pass at fixing it. I'll update the issue w/ the PR in a second.

@duplicate-issues
Copy link

Hey @christek91,

We did a quick check and this issue looks very darn similar to

This could be a coincidence, but if any of these issues solves your problem then I did a good job 😄

If not, the maintainers will get to this issue shortly.

Cheers,
Your Friendly Neighborhood ProBot

@frostming
Copy link
Contributor

Close in honor of #3237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants