Improve environment to replace inline activate virtualenv #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frost Ming <mianghong@gmail.com>
techalchemy
reviewed
Nov 21, 2018
| extra_dists = list(self.extra_dists) + extra_dists | ||
| for extra_dist in extra_dists: | ||
| if extra_dist not in self.get_working_set(): | ||
| extra_dist.activate(self.sys_path) | ||
| # Move the added paths to the front | ||
| new_paths = [] | ||
| for item in list(sys.path): |
There was a problem hiding this comment.
You'll need to do some normalization here, also I'm not totally sure you need to put things at the front. You can probably just do sys.path = list(set(sys.path) | set(original_path)) (why is this necessary though?)
There was a problem hiding this comment.
Oh, it is just taken from activate_this.py, where I think virtualenv paths should always take priority to other paths.
|
Close this for now as discussed. |
|
well you don't need to close -- just want to hold off merging until after the bugfix release since i want to keep back any changes that aren't specifically fixing things |
|
It doesn't matter, I will keep that branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix
environment.activated()as standard method to activate a virtualenv.PYTHONHOMEenv inside virtualenv (Fix pipenv installs into python installation and not virtualenv #3261)I am not confident with the windows CI, let's see.
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.