Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipenv install --skip-lock does not interpolate environment variables #3608

Closed
orf opened this issue Mar 11, 2019 · 3 comments
Closed

Pipenv install --skip-lock does not interpolate environment variables #3608

orf opened this issue Mar 11, 2019 · 3 comments
Labels
Status: Awaiting Update ⏳ This issue requires more information before assistance can be provided. Status: Needs More Information This issue does not provide enough information to take further action.

Comments

@orf
Copy link

orf commented Mar 11, 2019

Issue description

When running pipenv install --skip-lock pipenv fails with a plette.models.base.ValidationError. It appears environment variables are not expanded. pipenv install works fine.

Expected result

Both pipenv install invocations should work.

Actual result

You have a traceback like so:

    self.validate(data)
  File "/usr/local/Cellar/pipenv/2018.11.26_2/libexec/lib/python3.7/site-packages/pipenv/vendor/plette/lockfiles.py", line 80, in validate
    klass.validate(data[key])
  File "/usr/local/Cellar/pipenv/2018.11.26_2/libexec/lib/python3.7/site-packages/pipenv/vendor/plette/models/sections.py", line 70, in validate
    klass.validate(data[key])
  File "/usr/local/Cellar/pipenv/2018.11.26_2/libexec/lib/python3.7/site-packages/pipenv/vendor/plette/models/base.py", line 132, in validate
    cls.item_class.validate(d)
  File "/usr/local/Cellar/pipenv/2018.11.26_2/libexec/lib/python3.7/site-packages/pipenv/vendor/plette/models/base.py", line 67, in validate
    return validate(cls, data)
  File "/usr/local/Cellar/pipenv/2018.11.26_2/libexec/lib/python3.7/site-packages/pipenv/vendor/requirementslib/models/pipfile.py", line 59, in validate
    raise plette.models.base.ValidationError(data, v)
plette.models.base.ValidationError: {'url': 'https://${CREDENTIALS}@server.com/repository/pypi/simple', 'name': 'name'}

Steps to replicate

url = "https://${CREDENTIALS}@myserver/repository/pypi/simple"
name = "name"

[packages]

[dev-packages]
pytest = "*"

[requires]
python_version = "3.7"

Run pipenv install --skip-lock

@frostming frostming added the Type: Bug 🐛 This issue is a bug. label Mar 12, 2019
@frostming
Copy link
Contributor

@orf Can you verify the issue against master branch? I can't reproduce here. Thanks

@frostming frostming added Status: Needs More Information This issue does not provide enough information to take further action. Status: Awaiting Update ⏳ This issue requires more information before assistance can be provided. and removed Type: Bug 🐛 This issue is a bug. labels Mar 12, 2019
@bagrat
Copy link

bagrat commented Jul 30, 2019

That's probably because of the verify_ssl missing, which is required.

@orf
Copy link
Author

orf commented Jul 31, 2019

This indeed works in master @frostming. verify_ssl has no effect

@orf orf closed this as completed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Update ⏳ This issue requires more information before assistance can be provided. Status: Needs More Information This issue does not provide enough information to take further action.
Projects
None yet
Development

No branches or pull requests

3 participants