Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to override pip's --exists-action, or PIP_EXISTS_ACTION #3737

Closed
simion opened this issue May 9, 2019 · 1 comment · Fixed by #3738
Closed

Option to override pip's --exists-action, or PIP_EXISTS_ACTION #3737

simion opened this issue May 9, 2019 · 1 comment · Fixed by #3738
Labels
Category: Performance Issue relates to performance Category: Pip Requires pip update to address PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. Priority: Medium This item is medium priority and will be resolved whenever possible. Type: Behavior Change This issue describes a behavior change. Type: Enhancement 💡 This is a feature or enhancement request.

Comments

@simion
Copy link
Contributor

simion commented May 9, 2019

Hello,

I'm trying to find a way to specify --exists-action for pip install command, but it seems there's no way to override it.

Here: https://github.com/pypa/pipenv/blob/master/pipenv/core.py#L1506 you force "PIP_EXISTS_ACTION": vistir.misc.fs_str("w")

I need a way to set either PIP_EXISTS_ACTION=i or --exists-action=i (ignore a package if it's already installed)
This would make installation really really (really) fast, if the virtual environment exists.

We need this because we cache and restore .venv, and this option would make CI much faster :)

Thanks

@techalchemy techalchemy added Category: Performance Issue relates to performance Category: Pip Requires pip update to address PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. Priority: Medium This item is medium priority and will be resolved whenever possible. Type: Behavior Change This issue describes a behavior change. Type: Enhancement 💡 This is a feature or enhancement request. labels May 19, 2019
@techalchemy
Copy link
Member

Thanks for the suggestion and for the accompanying PR, I will toggle this a bit myself but I don't really see why we shouldn't do this... /cc @uranusjr @frostming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Performance Issue relates to performance Category: Pip Requires pip update to address PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. Priority: Medium This item is medium priority and will be resolved whenever possible. Type: Behavior Change This issue describes a behavior change. Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants