Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asdf Support #3875

Closed
jamesstidard opened this issue Jul 29, 2019 · 4 comments
Closed

Asdf Support #3875

jamesstidard opened this issue Jul 29, 2019 · 4 comments
Labels
Type: Enhancement 💡 This is a feature or enhancement request.

Comments

@jamesstidard
Copy link
Contributor

jamesstidard commented Jul 29, 2019

Hi,

I'm looking at switching from pyenv to asdf for managing my python installs, but it would be a shame to miss the QoL integration pipenv has with pyenv.

I forked the repo and had a look at how easy it would be to add. Seems pretty straight forward. I guess some things to consider are:

  • What if pyenv and asdf are both installed?
    I would assume pyenv takes priority as it's language specific. Or a user environment var to flag a preference.

  • Adding to an already fringe feature
    The pyenv integration, though I find very convent, is probably not considered that core to the project. Adding this extra python version manager integration is maybe just more to maintain.

If this has a chance of being picked up, I'd happily finish and document the changes.

link to asdf

Thanks.

@AlJohri
Copy link
Contributor

AlJohri commented Jul 31, 2019

I believe techalchemy added ASDF support already. See:

I'm not 100% sure if this is already released but the latest version of pythonfinder vendored into this repo already has ASDF support.

@frostming
Copy link
Contributor

If I understand correctly, the ASDF support in pythonfinder is about python finding, but the OP is talking about python installation.

In my opinion, it is a reasonable request, just need some refinement for the implementation.

@jamesstidard
Copy link
Contributor Author

If I understand correctly, the ASDF support in pythonfinder is about python finding, but the OP is talking about python installation.

Yeah, sorry I didn't make that too clear in my original post. pythonfinder does check for asdf installs currently. The hack-job fork I made uses to see if asdf is installed - just as pyenv installed are currently checked for.

In my opinion, it is a reasonable request, just need some refinement for the implementation.

I think one of the things that should be checked is if, not just asdf is installed, but the python plugin for asdf is also installed. I couldn't see how/if this is was handled for pyenv's equivalent python-build plugin. You can list installed plugins in asdf, whereas I think for pyenv the install command just doesn't show up unless the plugin is installed.

@frostming frostming added Type: Enhancement 💡 This is a feature or enhancement request. and removed triage labels Aug 6, 2019
@jamesstidard jamesstidard mentioned this issue Aug 6, 2019
2 tasks
@jamesstidard jamesstidard mentioned this issue Nov 9, 2019
2 tasks
@oz123
Copy link
Contributor

oz123 commented Jan 23, 2022

Seems fixed.

@oz123 oz123 closed this as completed Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

No branches or pull requests

4 participants