Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI docs broken #4778

Closed
Berbe opened this issue Aug 30, 2021 · 8 comments · Fixed by #5032 or #5148
Closed

CLI docs broken #4778

Berbe opened this issue Aug 30, 2021 · 8 comments · Fixed by #5032 or #5148
Labels
Type: Documentation 📖 This issue relates to documentation of pipenv.

Comments

@Berbe
Copy link

Berbe commented Aug 30, 2021

Issue description

CLI docs
CLI docs source

Expected result

CLI docs

Actual result

Empty page

@florisla
Copy link

It seems the whole https://pipenv.pypa.io/ website is having HTTP 403 errors.

This site is still listed as the documentation home of pipenv at the bottom of the repository README.

@matteius
Copy link
Member

The page @Berbe linked to for CLI docs renders the phrase Pipenv CLI Reference which is what CLI docs source has in the source. Otherwise it is just a blank set of documentation checked into the source. What is the ask here?

@matteius matteius added the Type: Documentation 📖 This issue relates to documentation of pipenv. label Dec 24, 2021
@kdickerson
Copy link

@matteius There used to be actual documentation at that location, WaybackMachine snapshot from May 8, 2021. Sometime between May 8, 2021 and Aug 12, 2021 the documentation disappeared.

Was the documentation intentionally removed?

@matteius
Copy link
Member

matteius commented Apr 6, 2022

I looked into this today. I see what is happening, but not yet why it would have changed behavior after 2021.5.29

The sphinx build error is: /home/matteius/pipenv/docs/cli.rst:6: ERROR: "<class 'pipenv.cli.options.PipenvGroup'>" of type "pipenv:cli" is not derived from "click.BaseCommand"

Verified in shell:

>>> from pipenv import cli
>>> import click
>>> isinstance(cli, click.BaseCommand)
False

For some reason in 2021.5.29 it is:

>>> from pipenv import cli
>>> import click
>>> isinstance(cli, click.BaseCommand)
True

@matteius
Copy link
Member

matteius commented Apr 6, 2022

Well I figured out what the change is -- we vendored click into the project, and so now in sphinx-click it is not detecting that we sub-class from click, because we are subclassing from pipenv.vendor.click. Not clear what the easy fix will be, but that is why the docs are blank for CLI currently.

@matteius
Copy link
Member

matteius commented Apr 6, 2022

I fixed it using the sphinx conf.py and patched the class of click to be our vendored class. The docs should generate upon the next release.

@akadouri
Copy link

akadouri commented May 2, 2022

@matteius the cli docs page (https://pipenv.pypa.io/en/latest/cli/) is still empty. There was a release a couple days ago so I assume the docs should have been generated?

@matteius matteius reopened this May 2, 2022
@matteius
Copy link
Member

matteius commented May 2, 2022

Well that's a bummer. It was definitely fixed in a recent release, that I verified. Apparently something about that monkeypatch for the docs build is fragile. Will look into it at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation 📖 This issue relates to documentation of pipenv.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants