-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
running script with pipenv run
will fail if args contains special characters on Windows
#4935
Comments
pipenv run
will fail if args contains special characterspipenv run
will fail if args contains special characters on Windows
Thanks for the detailed issue report. I guess we need to wait for upstream here. |
Thanks for your response. I think this feature is strange. However, upstream project already have an option to disable it. Therefore, it is the user's responsibility to take advantage and disadvantage of this feature. For this reason I think we need to change the settings for |
If this is something we can control, I think a PR can be merged. Not having a windows will make it hard to for me to test. If can, you are welcome to submit a PR. |
Thanks. I created a PR to fix it. |
Fixed in b60d37a |
Issue description
After updating pipenv, my scripts fail with exception. I don't know if there are any configurations to fix this problem, please tell me if it exists.
When
This problem happens when the following conditions are met
glob.glob
python standard function.Cause
version 2021.11.5 has updating dependency
click
from 7.1.2 to 8.0.1.click 8.0 has new feature like below. see: https://palletsprojects.com/blog/flask-2-0-released/
FYI: pallets/click#1096
Due to the above feature, All arguments are passed for
glob.glob
function and throws exception because the arguments are not for glob function for my script.[3-1]
in my example is invalid as glob format.Latest pipenv has same issue.
IMO, windows_expand_args=False should be set.
see: pallets/click#2135
Expected result
print
Hello world!
Actual result
throws Exception
Steps to replicate
building below Dockerfiles and running it on Windows.
Dockerfile_success
with pipenv version2021.5.29
will success with printingHello world!
.Dockerfile_fail
with pipenv version2021.11.5
will fail with throwing Exception.Dockerfile_success
Dockerfile_fail
main.py
Please run
$ pipenv --support
, and paste the results here. Don't put backticks (`
) around it! The output already contains Markdown formatting.If you're on macOS, run the following:
If you're on Windows, run the following:
If you're on Linux, run the following:
The text was updated successfully, but these errors were encountered: