Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed usage of fs_str from vistir #5062

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Removed usage of fs_str from vistir #5062

merged 3 commits into from
Apr 20, 2022

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Apr 20, 2022

This function was all about compatability of py2-py3.3 versions.
Later versions don't need it.

This PR replaces #5059 as I did too much havoc there with all the CI suggestions.

This function was all about compatability of py2-py3.3 versions.
Later versions don't need it.
@oz123 oz123 requested a review from matteius April 20, 2022 09:24
pipenv/utils/resolver.py Outdated Show resolved Hide resolved
Copy link
Member

@matteius matteius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- made a couple of notes to look into first.

@oz123 oz123 requested a review from matteius April 20, 2022 11:58
@oz123 oz123 requested a review from matteius April 20, 2022 12:14
@oz123 oz123 merged commit 2bf70b7 into main Apr 20, 2022
@oz123 oz123 deleted the drop-usage-of-vistir.fs_str branch April 20, 2022 14:17
oz123 added a commit that referenced this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants