Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendord cached_property #5169

Closed
oz123 opened this issue Jul 8, 2022 · 0 comments
Closed

Remove vendord cached_property #5169

oz123 opened this issue Jul 8, 2022 · 0 comments
Labels
Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.

Comments

@oz123
Copy link
Contributor

oz123 commented Jul 8, 2022

This is built in functool.cached_property since Python 3.8 and is redefined in many places we can import from without
fearing it will be removed:

$ git grep -r "class cached_property"
pipenv/patched/notpip/_vendor/distlib/util.py:class cached_property(object):
pipenv/patched/notpip/_vendor/distro/distro.py:    class cached_property:  # type: ignore
pipenv/patched/notpip/_vendor/pyparsing/core.py:    class cached_property:
pipenv/vendor/cached_property.py:class cached_property(object):
pipenv/vendor/cached_property.py:class cached_property_with_ttl(object):
pipenv/vendor/distlib/util.py:class cached_property(object):
@matteius matteius added the Type: Vendored Dependencies This issue affects vendored dependencies within pipenv. label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Projects
None yet
Development

No branches or pull requests

2 participants