Revert the exclusion of BAD_PACKAGES from batch_install #5275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when I was getting the rest of
pipenvto use the vendor'dpip, I ran up against this issue that caused me to addBAD_PACKAGESto prevent setuptools from being installed. The curious thing was the CI passed on python 3.10 -- through a recent interaction on issue #2364 and searching pip code for3, 10I found that the issue with installing setuptools after it had been uninstalled is diverted by patching to allow for usages ofsysconfigon all supported python versions. Based on this comment on the issue I opened inpipplus some additional CLI testing I did where I was able to install a specific version ofsetuptoolsusing the--systemflag, I think this change should be safe. pypa/pip#11389 (comment)The issue
Fixes #2364