Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to build isolation by default; support extra-pip-args on sync command. #5399

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

matteius
Copy link
Member

The issue

Lack of build isolation means that build requirements no longer are implicitly installed and have to be installed ahead of time. I am revisiting that decision to change the default isolation level because I feel it has already caused enough problems with existing workflows, and I realized an alternate solution is to recommend users that have issues requiring pre-requisites to pass --extra-pip-args="--no-build-isolation" in their install or sync commands.

Fixes #5391
Fixes #5398

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius requested a review from oz123 October 11, 2022 08:22
@oz123 oz123 merged commit 9bf7c8e into main Oct 11, 2022
@oz123 oz123 deleted the issue-5398 branch October 11, 2022 09:52
@nk9
Copy link

nk9 commented Oct 11, 2022

Thank you guys for engaging so quickly with this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants