Bump version requirementslib and more vendor clean up #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vistir removed echo and TemporaryDirectory, so these changes are needed to fix the code.
This was used only by yaspin.
This is not used by pipenv directly, nor by any vendored libraries. pip has it's own copy of idna.
This makes parse obsolete, removing ~1000 LOC.
This was only used in 1 place and could be removed with a simple regex.
Install parse in the vendor environment, as it is still used.
|
@matteius all tests pass, besides Python3.7, but this is unrelated to the changes I did. |
matteius
reviewed
Nov 21, 2022
matteius
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we now bumped requirementslib, we could now also bump vistir to 0.7.4.
This in turn forces us to make some tiny changes, and allows us to finally drop yaspin.