Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipenv 2022.12.17 ate my while loop #5546

Closed
neilferreira opened this issue Dec 19, 2022 · 3 comments · Fixed by #5548
Closed

pipenv 2022.12.17 ate my while loop #5546

neilferreira opened this issue Dec 19, 2022 · 3 comments · Fixed by #5548
Assignees
Labels
Type: Regression This issue is a regression of a previous behavior.

Comments

@neilferreira
Copy link

Issue description

I've described this issue in greater detail on https://github.com/neilferreira/pipenv-ate-my-while-loop - but essentially the pipenv release 2022.12.17 that came out this weekend is seemingly impacting a | while IFS= read -r foo; do statement in bash, and is ending the while loop as a result.

As per my example, this command works:

docker build --build-arg VERSION=2022.11.30 -t foo:latest .

Whereas this command fails:

docker build --build-arg VERSION=2022.12.17 -t foo:latest .

Expected result

I expect that running pipenv install -e . should not impact the bash script that is running it.

Actual result

Running pipenv install -e . is affecting the bash script that is running it.

Steps to replicate

git clone git@github.com:neilferreira/pipenv-ate-my-while-loop.git
cd pipenv-ate-my-while-loop
docker build --build-arg VERSION=2022.11.30 -t foo:latest .
docker build --build-arg VERSION=2022.12.17 -t foo:latest .

Provide the steps to replicate (which usually at least includes the commands and the Pipfile).

@matteius
Copy link
Member

I think this is related: sarugaku/requirementslib#353

Specifically, I think the issue is here:
image

@matteius matteius added the Type: Regression This issue is a regression of a previous behavior. label Dec 19, 2022
@matteius matteius self-assigned this Dec 19, 2022
@matteius
Copy link
Member

Actually that part changed to shell=True, but is ok, there is another spot in that file that didn't convert right, but I am thinking its better to avoid using shell=True -- I have a PR out to requirementslib to fix this.

@matteius matteius mentioned this issue Dec 19, 2022
2 tasks
@matteius
Copy link
Member

2022.12.19 has been released to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Regression This issue is a regression of a previous behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants