Requirementslib==2.3.0 #5672
Merged
Requirementslib==2.3.0 #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
approved these changes
Apr 29, 2023
oz123
requested changes
Apr 29, 2023
oz123
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @oz123 requirementslib==2.3.0 drops usage of vistir.
This PR brings pipenv up todate with requirementslib==2.3.0. It does also address the remaining usage of vistir which I was going to defer to @oz123, but I needed to get these changes in place to update my refactor of requirementslib PR (targeting 3.0.0) and so he can help review this instead :-D
For some reason when I vendor'd this in, I got some random import errors and failures in building so I also ripped the bandaid off that was modifying the sysconfig for the import paths -- we finally have correctly imported everything so those patches/hacks are no longer needed.
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.