Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the --keep-outdated flag and --selective-upgrade flags #5730

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

matteius
Copy link
Member

Drop the --keep-outdated flag and --selective-upgrade flags that have been deprecated in favor of update/upgrade commands.

Note:
Let's plan on doing this at the same time we bring in the new requirementslib 3.x series.
I want the next release before that to focus on bug fixes first.

The issue & Fix

These flags were deprecated and more correct resolution phases were added to the update and upgrade command.

Use instead:

  • update -- calls upgrade under the hood, upgrades the relevant packages in the lock file and installs them.
  • upgrade -- Only upgrade the relevant packages in the lock file (no install phase).

…been deprecated in favor of update/upgrade commands.
@matteius matteius marked this pull request as ready for review June 26, 2023 22:21
@matteius matteius requested a review from oz123 June 26, 2023 22:21
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY! removing all older code :-)

Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News item is missing.

@matteius matteius requested a review from oz123 July 5, 2023 05:17
@matteius matteius merged commit 9befcb6 into main Jul 5, 2023
@thisisrachelramos
Copy link

For those googling on what to do now that --keep-outdated is deprecated:

The flag --keep-outdated has been deprecated for removal...Consider using the new pipenv upgrade command to selectively upgrade packages.

source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants