Only search the Pipenv default index when an alternative index is not specified. #5737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
force-pushed
the
bugfix-restricted-package-indexes
branch
from
03fce11
to
b0ff31e
Compare
oz123
reviewed
Jun 18, 2023
| from pipenv.routines.lock import do_lock | ||
| from pipenv.utils.dependencies import pep423_name | ||
| from pipenv.vendor import click | ||
| from pipenv.vendor.requirementslib.models.requirements import Requirement | ||
| from pipenv.vendor.requirementslib.models.utils import get_version |
There was a problem hiding this comment.
Neat: removing in function imports to top level because of linter isn't something I favour.
Top level imports slow down the start time of programs. For command line tools which might have short execution time, this might be significant.
This might not have a huge impact here, though.
oz123
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
At some point pip changed behaviors of how it searches among the indexes to not always prefer pypi -- this difference caused inconsistency with the index restricted packages expectations.
Fixes #5736
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.