Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default specifier operator regression from v2023.6.18 #5764

Closed
sebastien-coavoux opened this issue Jun 30, 2023 · 1 comment · Fixed by #5765
Closed

Default specifier operator regression from v2023.6.18 #5764

sebastien-coavoux opened this issue Jun 30, 2023 · 1 comment · Fixed by #5765
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Type: Regression This issue is a regression of a previous behavior.

Comments

@sebastien-coavoux
Copy link
Contributor

sebastien-coavoux commented Jun 30, 2023

Issue description

Describe the issue briefly here.

Look like requirement lib update change the format expected in a Pipfile to specify version requirements

Expected result

Expecting package = "X.Y.Z" to be a valid spec

Actual result

Stack trace with Invalid specifier: '0.95.0'

Steps to replicate

mkdir -p  /tmp/pyenvbug
cd /tmp/pyenvbug/
virtualenv env
. env/bin/activate
echo -e '[packages]\nfastapi = "0.95.0"\n' > Pipfile

pip install pipenv==2023.6.26
pipenv install  # fails with: Invalid specifier: '0.95.0'

pip install pipenv==2023.6.18
pipenv install  # works

deactivate
cd
rm -rf /tmp/pyenvbug

Looking at the code, look like the operator is compulsory so that package = "==X.Y.Z" is the way to specify version requirement

Correct me if I am wrong, but the syntax package = "X.Y.Z" is / was expected to work before, right?

I have a bunch of Pipfile to fix with the "new" syntax if this is the way moving forward.

@matteius
Copy link
Member

You are probably right, this is likely a regression. If you see where to patch requirementslib or pipenv for this issue feel free to open a PR against pipenv and we can handle porting the fix over to reqlib -- otherwise I will look into it when I can get some more time.

@matteius matteius added Type: Regression This issue is a regression of a previous behavior. Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. labels Jun 30, 2023
@matteius matteius changed the title Regression from v2023.6.18 with requirement lib update Default specifier operator regression from v2023.6.18 with requirementlib update Jul 1, 2023
@matteius matteius changed the title Default specifier operator regression from v2023.6.18 with requirementlib update Default specifier operator regression from v2023.6.18 Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Type: Regression This issue is a regression of a previous behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants