-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression from v2023.6.18 for editable package dependencies #5766
Comments
Interesting, I suspect this may only be an issue for when the transitive dependencies are defined in the pyproject.toml? This will require further investigation towards a fix, thanks for your report! |
Initial analysis revealed that |
@justin-yan I just had a good test run for the proposed fix of this issue if you would like to try out that branch. I just pushed a unit test as well that failed on main and passed on this branch. |
Just tried it out on |
Issue description
When installing a package in editable mode, pipenv does not include its transitive dependencies on version 2023.06.26, when it does on version 2023.06.18.
I've created an example repo here: https://github.com/justin-yan/pipenvtest/tree/1aeb6b6d28662319a0250cdd8d8a7220812ed358 where the
pipenvtest
package is defined with one dependency (pyyaml
): https://github.com/justin-yan/pipenvtest/blob/1aeb6b6d28662319a0250cdd8d8a7220812ed358/pyproject.toml#L10Expected result
pipx install pipenv==2023.06.18 --force
pipenv lock
from a clean clone of this repo.Results in a Pipfile.lock that includes the pyyaml package:
Actual result
pipx install pipenv==2023.06.26 --force
pipenv lock
from a clean clone of this repo.Results in a Pipfile.lock that does not include the transitive dependencies of
pipenvtest
:The text was updated successfully, but these errors were encountered: