Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extras not being included for pypi packages in requirements command #5784

Merged
merged 4 commits into from
Jul 9, 2023

Conversation

matteius
Copy link
Member

@matteius matteius commented Jul 7, 2023

The issue

Fixes #5783
Fixes #5780

The fix

  • Consider extras for pypi or private index packages.
  • Consider file and path requirements.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius requested a review from oz123 July 7, 2023 03:35
@matteius
Copy link
Member Author

matteius commented Jul 7, 2023

FYI -- I plan to look more into the flakey test test_convert_deps_to_pip_star_specifier outside of this PR.

@matteius matteius merged commit ea82bae into main Jul 9, 2023
9 of 19 checks passed
@matteius matteius deleted the issue-5783 branch July 9, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant