Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipenv update --outdated became noisy #5854

Closed
BorgPrincess opened this issue Aug 22, 2023 · 4 comments · Fixed by #5897
Closed

pipenv update --outdated became noisy #5854

BorgPrincess opened this issue Aug 22, 2023 · 4 comments · Fixed by #5897
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Type: Regression This issue is a regression of a previous behavior.

Comments

@BorgPrincess
Copy link

BorgPrincess commented Aug 22, 2023 •
edited
Loading

Issue description

pipenv update --outdated writes extensive INFO logs to console.
Flags --bare and --quiet do not change this.
The new behaviour began in release 2023.8.19 and persists at least through release 2023.8.22.

Expected result

Console output without added flags; possibly less with --bare or --quiet:

Running $ pipenv lock then $ pipenv sync.
Building requirements...
Resolving dependencies...
✔ Success!
Building requirements...
Resolving dependencies...
✔ Success!
Building requirements...
Resolving dependencies...
✔ Success!
Building requirements...
Resolving dependencies...
✔ Success!
All packages are up to date!

Actual result

More than 120k of log output to the console:
pipenv.log.txt

Steps to replicate

Any one of

pipenv update --outdated
pipenv --bare update --outdated
pipenv --quiet update --outdated

pipenv.support.txt
@matteius matteius added the Type: Regression This issue is a regression of a previous behavior. label Aug 23, 2023
@phette23
Copy link

To add to this, even with PIPENV_QUIET=true or --quiet the command is still noisy, filled with INFO:pipenv.patched.pip... messages.

@matteius
Copy link
Member

We'll want to figure out how to make those flags reduce the output, without breaking verbose again. The line I removed that caused this was just globally silencing the pip logging which was leading to a lot of reports where folks could not debug why their lock phases were failing.

@matteius matteius added the Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. label Aug 25, 2023
@matteius matteius mentioned this issue Aug 31, 2023
Merged
2 tasks
@matteius
Copy link
Member

I believe #5897 solves for this.

@BorgPrincess
Copy link
Author

BorgPrincess commented Sep 4, 2023 •
edited
Loading

Yes, that fixed it!
Thank you very much! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Type: Regression This issue is a regression of a previous behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set log level in resolver to WARN when verbose is not passed pypa/pipenv
3 participants
@matteius @phette23 @BorgPrincess