Top level Pipfile sys_platform markers should be transitive #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2023
cclauss
approved these changes
Sep 1, 2023
Comment on lines
+476
to
+477
| markers = self._fold_markers(dependency_tree, comes_from) | ||
| if markers: |
There was a problem hiding this comment.
Suggested change
| markers = self._fold_markers(dependency_tree, comes_from) | |
| if markers: | |
| if markers := self._fold_markers(dependency_tree, comes_from): |
There was a problem hiding this comment.
I guess we can use the walrus operator, but it won't work in 3.7 so we essentially can hold this back until we drop 3.7, but I have mixed feelings about it with the open reports about hash collection against some private indexes. 🤔
There was a problem hiding this comment.
I am fine to remain Walrus-less. My two freelance clients are both Python 3.11-only so I forgot about 3.7 in this case.
use walrus operator Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
This reverts commit b2205a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
I want transitive platform locking to work better.
The fix
By following the resolution chain (where the package came from) we can get back to the Pipfile entry and apply the same sys_platform markers the user intended.
Additionally add a top level platform_machine specifier that works the same way.
Note: Adding directly to the markers will behave different with the pip resolver than adding them as distinct specifier keys in the Pipfile.
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.