-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subdirectory fragment of git located Dependencies of Packages (sub-dependency) aren't added to Pipfile.lock #6120
Comments
I did some more digging - sorry for not catching the previous reported issues, search wasn't turning up anything with my keywords. A PR in 2020 added support for direct VCS subdependencies support (#4259) after a few reported issues - the behavior was to keep the link "mostly" as is (it's even tested in
In my testing, if I take my repro-case and the test's repro-case, both result in the same error where it's not possible to install with this entry, since the subdirectory fragment is never taken into consideration
I imagine that previously, it used to work though (without the subdirectory key added to the Pipfile.lock entry). What is the correct fix in this situation @matteius? Should I have a patch for I'd be super eager to help more, let me know what solution you prefer! |
@AlexandreArpin your patch sounds like the right direction to head in -- I'm getting lock resolution errors though with the egg fragment syntax, does your patch resolve for that as well? |
Issue description
When installing a package that has a git dependency with a subdirectory, the subdirectory isn't added to the Pipfile.lock.
Manually adding the subdirectory to the Pipfile.lock entry for that dependency fixes the issue.
Installing the library with
python -m pip install
works as well.Expected result
Subdirectory is added to that dependency's Pipfile.lock
Actual result
Pipfile.lock has the following entry:
pipenv lock --verbose
Steps to replicate
I have created a repository that has a reproduction case.
my-app-gitssh-dep
subdirectorypipenv lock
Provide the steps to replicate (which usually at least includes the commands and the Pipfile).
Pipenv version:
'2023.12.1'
Pipenv location:
'C:\\Users\\Alex\\AppData\\Local\\Programs\\Python\\Python310\\lib\\site-packages\\pipenv'
Python location:
'C:\\Users\\Alex\\AppData\\Local\\Programs\\Python\\Python310\\python.exe'
OS Name:
'nt'
User pip version:
'23.3.2'
user Python installations found:
PEP 508 Information:
The text was updated successfully, but these errors were encountered: