Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git packages with pipx upgrade-all #75

Closed
petobens opened this issue Jan 27, 2019 · 11 comments
Closed

Update git packages with pipx upgrade-all #75

petobens opened this issue Jan 27, 2019 · 11 comments

Comments

@petobens
Copy link

petobens commented Jan 27, 2019

This might be a bit far fetched but imagine I've installed some package with --spec git+https:.../some_branch/ and that package gets an update i.e a new commit in some_branch.
Can pipx pull those new changes upon pipx upgrade? (AFAICT it doesn't do this already).
Thanks!

@cs01
Copy link
Member

cs01 commented Jan 27, 2019

It can do this already with something like this

pipx upgrade pipx-app --spec git+https://github.com/cs01/pipx@branch-name

@petobens
Copy link
Author

Thanks for the quick reply. My real use case is that I want this to work with pipx upgrade-all which doesn't work at the time being right?

@petobens petobens changed the title Update git packages with pipx update Update git packages with pipx upgrade-all Jan 27, 2019
@cs01
Copy link
Member

cs01 commented Jan 27, 2019

Correct, it won't work in that case.

@petobens
Copy link
Author

Ok. If there are plans to implement something that will allow such behavior then we can leave this open; otherwise feel free to close. Thanks once again

@cs01
Copy link
Member

cs01 commented Jan 27, 2019

I could add a file to the virtual env. Something like a .pipxrc with JSON that includes various keys, the "spec" being one of them. Then pipx could recognize and read that file, and re-use the same origin for all updates.

If people like this idea I can add it. As always, feel free to vote with a thumbs up or provide an alternative suggestion to vote on.

@itsayellow
Copy link
Contributor

I just did an upgrade-all, and unfortunately it overwrote one of my personal git-based pipx installs with one from pypi that is completely unrelated... They just happened to have the same name. In this case it was a pretty serious breakage.

@cs01
Copy link
Member

cs01 commented Jun 3, 2019

@itsayellow ah so sorry to hear that. The .pipxrc file probably would have prevented that from happening, but I haven't gotten around to adding it.

@itsayellow
Copy link
Contributor

thanks @cs01 , I was perplexed for a while at what was happening, but I'm ok now. Just wanted to add another motivation for this issue. Thanks for all your work on pipx.

@itsayellow
Copy link
Contributor

This is fixed via #222, for cases where the package version number changes (the most reliable way to detect an upgrade is needed.)

@petobens
Copy link
Author

petobens commented Jan 2, 2020

Thank you! Is there going to be a release soon?

@cs01
Copy link
Member

cs01 commented Jan 2, 2020

Yes, we're getting close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants