-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.9.0 final release #199
Comments
I'm waiting for @dnicolodi to have a chance to try with meson-python, though people with |
Thank you for the quick reply. I'm working on pdm-backend but without the bundled dependencies. I'll wait then. |
It is my understanding that for supporting PEP 639 correctly the license expression needs to be validated and normalized. This is left to the build backends to do via the new |
That's SHOULD, not MUST. Though it does make me wonder if we should drop the immutability of non-dynamic fields. Setting this to a normalized license expression is a valid thing to do. Currently it can be done with Another option would be to also implement |
I rather like shipping with validation in the first version, so we don't create backward incompat later. |
I think doing validation and normalization in the build backend is the right thing. I suppose an invalid license expression would be rejected at upload time otherwise. Wouldn't it? AFAICT, both validation and normalization require keeping a list of valid licenses and I don't think that there is value in duplicating that in I'm agnostic whether the validation should be implemented in |
I don't want to maintain a list of licenses here, and I don't want to force a really recent (not yet released!) version of packaging as a required dependency, so I think we should leave it up to the backends, but have a clear example of how to do it with packaging, or maybe a way to opt in if packaging is new enough. We can do this by default for #140. Dynamic fields are mutable. Only ones not listed in the Dynamic table are immutable. |
What I'd probably do in scikit-build-core would be to warn if the validation isn't available, asking users to update packaging. We could do that here instead - validate if packaging is new enough, otherwise warn that it can't be validated. |
I'll be happy with that solution or with implementing the validation in the back-end. Although in the latter case, having the possibility to mutate the |
I've prepared mesonbuild/meson-python#681 and as far as I can tell everything looks good. @henryiii I would appreciate if you could give a cursory look at that PR to see if I did miss anything in the implementation of PEP 639. |
I was trying to keep a similar (but incorrectly implemented) protection in 0.8 and earlier. But I'm thinking this isn't helpful. Some sort of API to easily ask "is this field in the dynamic list" would probably be better. |
Isn't that there already? It is enough to compare a field name with the content of the On the other hand, bypassing the check is trivial thus if it is required only to update |
Yes, doesn't really need a new API. Very tempted to drop it - simpler, and I've also had to work around it here: |
All PRs are passing, so I'll release soon unless anyone has last-minute objections! |
Thank you! |
Hello. What are the plans for the final release of 0.9.0? Using beta releases means some additional work for me so I'm asking whether it's worth it and we'll have only beta releases in the near future or we can expect a final release soon. Thank you.
The text was updated successfully, but these errors were encountered: