-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop advertising adding wheel
as an unconditional PEP 517 build dependency
#203
Comments
That sounds more complex than I think you mean - isn't it just the following one line? https://github.com/pypa/sampleproject/blob/main/pyproject.toml#L153 |
You're right. I think there was some other repo under @pypa that has multiple project examples in it that I confused this one with. |
I was thinking of https://github.com/pypa/sample-namespace-packages, it seems. |
#204 addresses this. |
@chrysle as I said above — I originally thought of a different repo. Also, that PR does too much stuff than just removing 9 bytes from a single place, which would've been much cleaner. |
I guess this can be closed, nevertheless? What's done is done. |
It's already pulled in by
setuptools
automatically, when building wheels is requested from the frontend. If only sdists are being build,pyproject.toml
shouldn't forcefully inject this dependency into the ephemeral build env.This has mostly been cleaned up from other places in the ecosystem and should be done here as well.
Related PRs:
wheel
as a build dep fallback build#716wheel
as a build dep fallback pip#12449wheel
in the context of PEP 517 setuptools#3056Action items:
pyproject.toml
files that havesetuptools
in their[build-system].requires
wheel
from the lists where it's also presentThe text was updated successfully, but these errors were encountered: