Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reason to avoid including git_archive plugin into this package no longer applies #578

Closed
eli-schwartz opened this issue Jun 7, 2021 · 3 comments · Fixed by #580
Closed

Comments

@eli-schwartz
Copy link

cf. Changaco/setuptools_scm_git_archive#17

I opened a discussion on the git mailing list back in January: https://public-inbox.org/git/4f65f02c-1d16-aa2c-3e7b-28d807b9ebe9@archlinux.org/T/

As a result, the git 2.32 release notes from yesterday, mention this:

  • "git log --format='...'" learned "%(describe)" placeholder.

Full documentation on the format:
https://git-scm.com/docs/git-log/2.32.0#Documentation/git-log.txt-emdescribeoptionsem

It's now possible to do this:

$ cat .git_archival.txt
describe-name: $Format:%(describe)$

As such, Git/Github now (or will as soon as Github upgrades the version of git used by the server) support "sufficient metadata for untagged/followup commits", and a consistent UX can be achieved.

@RonnyPfannschmidt
Copy link
Contributor

AWESOME, THANK YOU FOR LETTING LETTING ME KNOW

I have been waiting for this for about a decade

@eli-schwartz
Copy link
Author

eli-schwartz commented Jun 7, 2021

Ha, well, I was sort of obligated to tell you :) considering that I independently came to the conclusion setuptools_scm_git_archive was insufficient if it could not do git describe, and having used (and had trouble with) github archives using setuptools_scm before, I selfishly wanted to be able to build them out of the box... I only realized this morning while submitting tickets that this was a documented shortcoming/wish item.

I'm delighted I was able to make your day (decade?). :D

@webknjaz
Copy link
Member

webknjaz commented Jun 8, 2021

FINALLY <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants